Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PnP resolver #255

Merged
merged 13 commits into from
Oct 14, 2023
Merged

PnP resolver #255

merged 13 commits into from
Oct 14, 2023

Conversation

koshic
Copy link
Collaborator

@koshic koshic commented Oct 14, 2023

No description provided.

@koshic koshic mentioned this pull request Oct 14, 2023
Closed
@koshic koshic requested a review from iambumblehead October 14, 2023 20:02
@koshic
Copy link
Collaborator Author

koshic commented Oct 14, 2023

Next step is to create unit tests. @iambumblehead which approach do you prefer - real setup with yarn pnp or some test with mocked pnpapi module? Looks like the second one is much more simple.

iambumblehead
iambumblehead approved these changes Oct 14, 2023
View reviewed changes
Copy link
Owner

@iambumblehead iambumblehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

src/esmockModule.js Outdated Show resolved Hide resolved
@iambumblehead
Copy link
Owner

Next step is to create unit tests. @iambumblehead which approach do you prefer - real setup with yarn pnp or some test with mocked pnpapi module? Looks like the second one is much more simple.

Whatever you think is best is okay with me and we could add or change things later any time anyway

@koshic koshic requested a review from iambumblehead October 14, 2023 22:56
@koshic koshic linked an issue Oct 14, 2023 that may be closed by this pull request
Support Yarn PnP resolver out of the box #253
Closed
@koshic koshic merged commit abcead1 into main Oct 14, 2023
8 checks passed
@koshic koshic deleted the pnp-resolver branch October 14, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iambumblehead iambumblehead iambumblehead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Yarn PnP resolver out of the box
2 participants
@koshic @iambumblehead